Conversation
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Left a comment on the Jira ticket!
| "path": "./node_modules/cz-conventional-changelog" | ||
| } | ||
| }, | ||
| "prettier": "@ionic/prettier-config", |
Member
Author
There was a problem hiding this comment.
Because it hasn't been updated in so long that it breaks everything to try to include it. Nothing seems to use it anymore, so moved away from it here too.
brandyscarney
previously approved these changes
Jul 2, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Tested it out and everything looks good now! I did have one comment about the prettier change though.
ShaneK
added a commit
that referenced
this pull request
Aug 19, 2026
* feat!: support Angular 21 and 22 via peerDependencies (#531) * fix(ci): fixing eslint and prettier * feat!: support Angular 21 and 22 via peerDependencies * fix: regenerating lock files * fix(schematics): default page and component schematics to standalone * chore(npm): updating package-lock.json * fix(schematics): update templates to Ionic 9 component import paths * fix(schematics): repair generated component code and route registration BREAKING CHANGE: Generated code now targets Ionic 9 and Angular 21 or 22. Pages and components import `IonicModule` from `@ionic/angular/lazy` and standalone components from the `@ionic/angular` root, which is the Ionic 9 export layout, so generated code no longer compiles against Ionic 8. The `page` and `component` schematics now default to standalone, and peerDependencies drop Angular 20 and below.
ShaneK
added a commit
that referenced
this pull request
Aug 19, 2026
* docs: correct typo in monorepo description (#522) * chore(npm): Update release npm action to stop using tokens (#526) * Update release yaml to use trusted publishers approach * Update cd.yml * Finetuned workflows triggers and improved linting issues (#527) * feat(many): support for Ionic Framework v9 (#532) * feat!: support Angular 21 and 22 via peerDependencies (#531) * fix(ci): fixing eslint and prettier * feat!: support Angular 21 and 22 via peerDependencies * fix: regenerating lock files * fix(schematics): default page and component schematics to standalone * chore(npm): updating package-lock.json * fix(schematics): update templates to Ionic 9 component import paths * fix(schematics): repair generated component code and route registration BREAKING CHANGE: Generated code now targets Ionic 9 and Angular 21 or 22. Pages and components import `IonicModule` from `@ionic/angular/lazy` and standalone components from the `@ionic/angular` root, which is the Ionic 9 export layout, so generated code no longer compiles against Ionic 8. The `page` and `component` schematics now default to standalone, and peerDependencies drop Angular 20 and below. --------- Co-authored-by: mohammad altamash <78483966+Shaikhaltamash861@users.noreply.github.com> Co-authored-by: Gonçalo M. <goncalo.martins@outsystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, eslint and prettier checks are no-ops and the limit for support is at Angular 20. This PR re-enables eslint and prettier checks and adds support for both Angular 21 and Angular 22. It is a breaking change due to dropping support for Angular 20.
Change Type